Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading optimization #82

Open
1 task
s0lst1ce opened this issue Dec 5, 2019 · 2 comments
Open
1 task

Reading optimization #82

s0lst1ce opened this issue Dec 5, 2019 · 2 comments
Labels
enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality
Milestone
Long term develop...

Comments

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Dec 5, 2019

My feature request is about

  • Changing a feature

Description of the solution I'd like
Currently configs and help description are read from the dis every time they need to be accessed.

Alternatives I've considered
Have the ConfigFile object only read and write when needed, using the RAM otherwise. This would make things significantly faster.

What needs to be done

  • Change ConfigFile behavior
@s0lst1ce s0lst1ce added enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality labels Dec 5, 2019
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented Dec 8, 2019

The same should be done for Translator

@s0lst1ce s0lst1ce added this to the Long term development milestone Mar 13, 2020
@s0lst1ce
Copy link
Collaborator Author

In the meantime we could switch from the json module to orjson which is much faster and more reliable. It would alleviate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality
Projects
None yet
Milestone
Long term development
Development

No branches or pull requests
1 participant
@s0lst1ce