Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slap command format enhance #111

Closed
3 tasks done
adrienluitot opened this issue May 4, 2020 · 2 comments
Closed
3 tasks done

Slap command format enhance #111

adrienluitot opened this issue May 4, 2020 · 2 comments
Assignees
Labels
command issues related to bot commands enhancement New feature or request

Comments

@adrienluitot
Copy link
Collaborator

adrienluitot commented May 4, 2020

My feature request is about
Enhance the design/format of the command ::slap.

Description of the solution I'd like
The slap command should be deleted after the embed, it's a little redundant otherwise.
Also the embed is a little big and information are redundant too (see the image below).
Last thing, the reason isn't really readable, it's hard too see why the user has been slapped. The reason should be highlighted (with a separation and/or bold).

Additional context
slap redundancy

What needs to be done

  • Delete the command
  • Avoid redundancy
  • Highlight the reason
@adrienluitot adrienluitot added enhancement New feature or request command issues related to bot commands labels May 4, 2020
@s0lst1ce s0lst1ce linked a pull request May 6, 2020 that will close this issue
@s0lst1ce
Copy link
Collaborator

s0lst1ce commented May 6, 2020

For this remember to change the way slaps work so that it becomes independent of slap behavior and doesn't require the command message. This is indeed an ugly implementation.

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented May 8, 2020

Done with latest commit.

@s0lst1ce s0lst1ce closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command issues related to bot commands enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants