Incomplete CSV import for type 'media'

[tybw]

Summary

Importing 'media' type via CSV using console command resulted in incomplete data.

Description

1. path column in bitbag_cms_media table was not set.
2. link column in bitbag_cms_media table was not set.
3. bitbag_cms_media_channels table was empty.
4. bitbag_cms_media_sections table was set, but when deleting records from bitbag_cms_media on database level, the delete operation was not cascading to bitbag_cms_media_sections.

Version

Sylius version: 1.4.0
Bitbab SyliusCmsPlugin version: 2.3.0

Details

The command used:

bin/console bitbag:import:csv media media.csv

The CSV file header is as follows:

"channels","code","type","sections","image","name_en_NZ","content_en_NZ","link_en_NZ"

Leaving the column image blank or skipping the whole column from the CSV file won't help because exception occurs:

Import failed at index 42. Exception message: File cannot be blank.  

Solutions and Questions

I managed to fix problem 1, 2 and 3 with some quick fixes to src/Importer/MediaImporter.php.
Is there any reason against these fixes?

1. Add to line 83 the following:

$media->setPath($this->getColumnValue('image', $row));

2. Add to line 81 the following:

$media->setLink($this->getTranslatableColumnValue('link__locale__', $locale, $row));

3. Add to line 106 the following:

'link__locale__'

4. Add to line 85 of the same file the following:

$this->importerChannelsResolver
     ->resolve(
         $media,
         $this->getColumnValue(self::CHANNELS_COLUMN, $row)
     );

As for problem 4, I saw from the entity's doctrine orm settings src/Resources/config/doctrine/Media.orm.yml that onDelete: CASCADE was set for the section side of the many-to-many relation only. Is there any reason it is not set for the block side of the relation?

    manyToMany:
        sections:
            targetEntity: BitBag\SyliusCmsPlugin\Entity\SectionInterface
            joinTable:
                name: bitbag_cms_media_sections
                joinColumns:
                    media_id:
                        referencedColumnName: id
                inverseJoinColumns:
                    section_id:
                        referencedColumnName: id
                        onDelete: CASCADE