Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap no more optional in 2.0 ? #168

Closed
wadjeroudi opened this issue Jul 9, 2018 · 1 comment
Closed

Sitemap no more optional in 2.0 ? #168

wadjeroudi opened this issue Jul 9, 2018 · 1 comment

Comments

@wadjeroudi
Copy link
Contributor

wadjeroudi commented Jul 9, 2018

With this commit 5a651cb
in 2.0, the sitemap is always defined, so if you don't have the sylius sitemap plugin it will fire an error :

  The service "bitbag_sylius_cms_plugin.sitemap_provider.page" has a dependency on a non-existent service "sylius.sitemap_url_factory".  

Is it a mistake ? @bitbager

@bitbager
Copy link
Member

In 2.0 CMS will use the Sitemap plugin by default. We will mention it in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants