Fix WeightDependentPostPre Post-synaptic update #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The difference of `wmax` and the actual weights had been mistakenly calculated as `(self.wmax - self.connection.wmin)`, which was a fixed value.
The same fix also needed for the conv3d_connection_update
|
Good catch! thank you for helping out! |
|
I just noticed the same error in the Thank you! |
Hananel-Hazan
added a commit
that referenced
this pull request
Jan 2, 2022
Continue Fix WeightDependentPostPre Post-synaptic update #534
|
Right! just pushed fix for that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference of
wmaxand the actual weights had been mistakenly calculated as(self.wmax - self.connection.wmin), which was a fixed value.