Maintenance updates: docformatter fixes, and mypy/docs updates #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminSchubert
changed the title
BenjaminSchubert
force-pushed
the
bschubert/fix-docformatter
branch
from
49acf33
to
3077aa4
Compare
PyCQA/docformatter#137 changed how docformatter behaves to return 3 when files were modified, so we need to be able to tell that this is an allowed return code in some cases.
Also pin docformatter to <1.7.1, as it starts misbehaving with :param entries
BenjaminSchubert
force-pushed
the
bschubert/fix-docformatter
branch
from
3077aa4
to
caf3b30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 87.46% 87.50% +0.04%
==========================================
Files 51 51
Lines 2297 2305 +8
Branches 296 297 +1
==========================================
+ Hits 2009 2017 +8
Misses 226 226
Partials 62 62 ☔ View full report in Codecov by Sentry. |
BenjaminSchubert
force-pushed
the
bschubert/fix-docformatter
branch
from
170e5d8
to
2801432
Compare
Otherwise, when tests hang, they take 6 hours to finish. Our mean time is 8 minutes, thus 15 should be plenty of headroom The pypy tests seem to hang on GitHub Actions and we dont' get logs for what happened. Running them serially seems to gix the problem, let's do that for now
BenjaminSchubert
force-pushed
the
bschubert/fix-docformatter
branch
from
2801432
to
7eb6df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCQA/docformatter#137 changed how docformatter behaves to return 3 when files were modified, so we need to be able to tell that this is an allowed return code in some cases.