Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ament export targets #778

Closed

Conversation

Ryanf55
Copy link

@Ryanf55 Ryanf55 commented Feb 23, 2024

Purpose

Upgrade the support to latest ament recommendations, which uses CMake targets.

Addtions

I added a CI task to check it works. The stuff in export folder is merely to check the installation of BTCPP is correct.

Ticket

Closes #751

CI status

CI will be red until the next humble sync.

* Remove legacy ament functions
* Add ament_export_targets
* Match namespace for conan and ROS
* Depends on ament/ament_cmake#498 merging and
  backport to humble
* Add CI for export tests and colcon building

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
@facontidavide
Copy link
Collaborator

Red CI....

@Ryanf55
Copy link
Author

Ryanf55 commented Feb 23, 2024

Red CI....

Yes, Ill get it green after sync. For now, I'll put this in draft.

If you want some of the CI stuff merged in a separate MR that can go in now, I'm happy split it up.

@facontidavide
Copy link
Collaborator

closing this, unti it passes CI checks

@Ryanf55
Copy link
Author

Ryanf55 commented Jul 30, 2024

Do you have ability to re-run CI on this? It should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider updating to ament_export_targets (Modern CMake)
2 participants