pause playback when settings page is opened, and don't reload frames …

…afterwards (#64)
BattlesnakeOfficial · Oct 5, 2022 · 71e9ab4 · 71e9ab4
1 parent 32474dc
commit 71e9ab4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/src/components/game.jsx b/src/components/game.jsx
@@ -101,15 +101,19 @@ class Game extends React.Component {
       this.props.toggleTheme(options.theme);
     }
 
-    if (options.game && options.engine) {
-      this.hideLogo = options.hideLogo === "true";
-      this.hideScoreboard = options.hideScoreboard === "true";
-      this.showFrameScrubber = options.showFrameScrubber;
-      this.title = options.title && decodeURIComponent(options.title);
-      this.props.setGameOptions(options);
-      this.props.fetchFrames();
-    } else {
+    if (!(options.game && options.engine)) {
       this.invalidArgs = true;
+      return;
+    }
+
+    this.hideLogo = options.hideLogo === "true";
+    this.hideScoreboard = options.hideScoreboard === "true";
+    this.showFrameScrubber = options.showFrameScrubber;
+    this.title = options.title && decodeURIComponent(options.title);
+    this.props.setGameOptions(options);
+
+    if (this.props.frames.length === 0) {
+      this.props.fetchFrames();
     }
   }
 

diff --git a/src/components/settings/SettingsPage.jsx b/src/components/settings/SettingsPage.jsx
@@ -13,7 +13,7 @@ import {
 import PlaybackSpeed from "./playback/PlaybackSpeed";
 import styles from "./SettingsPage.module.css";
 import { useHistory } from "react-router-dom";
-import { togglePlayButtons, themeChanged } from "../../actions";
+import { togglePlayButtons, pauseGame, themeChanged } from "../../actions";
 
 const SettingsPage = () => {
   const history = useHistory();
@@ -25,6 +25,7 @@ const SettingsPage = () => {
 
   useEffect(() => {
     dispatch(togglePlayButtons("hide"));
+    dispatch(pauseGame());
   });
 
   function dispatchSpeedChange(fps) {