Question: Restored shell buffers have no processes

[khtan]

Hi,

I am using the latest Spacemacs 0.999.0@28.2 which bundles persp-mode by default.
Emacs: 28.2 on Windows 10
persp-mode.el: 3.0.7 ( which I believe is the latest )

Part of my workspace consists of several shell buffers with their own default directories.
I used persp-mode to save my perspectives. When I load them back, all the shell buffers have no processes.

I believed this problem was fixed in [[https://github.com//issues/76][Restoring shell #76]] way back in 2017. If that is so, am I missing something simple?

Thanks for a very useful tool.

[Bad-ptr]

What command do you use to start "shell" buffers? Is it the M-x shell RET?
Do you have this https://gist.github.com/Bad-ptr/1aca1ec54c3bdb2ee80996eb2b68ad2d#file-persp-shell-el in your config?

Maybe you get some related output in *Messages* buffer?

You can try the following:

1. Add this to config:

(with-eval-after-load "persp-mode"
(persp-def-buffer-save/load
 :mode 'shell-mode
 :mode-restore-function #'(lambda (_mode) (message "[ATTENTION]: Restoring shell proces for %S buffer" (current-buffer)) (shell))
 :tag-symbol 'def-shell
 :save-vars '(major-mode default-directory)))

2. Restart Emacs
3. Create some shell buffers
4. Save perspectives to file
5. kill shell buffers
6. Try to load perspectives from file
7. Try to restart emacs and see if it will be autorestored.

[khtan]

Yes, I am creating M-x shell and then renaming them to keep them distinct.

Thank you for your information. It is almost working.
I am using Spacemacs, so I placed the code snippet in .spacemacs dotspacemacs/user-config() section.

I created a shell, set its working directory to "~/bin" and named it S-bin
I created and saved a perspective called 'test' and added S-bin to the perspective.
When I restart Spacemacs and loaded the perspective 'test', I get 2 buffers:

• shell * Shell:run ~/bin
  S-bin 0 Fundamental

So S-bin did not get associated with the shell.

I have uploaded the test file below.
To allow the 'test' file to be uploaded, I've renamed it 'test.txt'.

test.txt

[Bad-ptr]

But after restart do you have any messages in *Messages* buffer starting with:
[ATTENTION]: Restoring shell proces for

[khtan]

Yes, my Messages buffer does say:
[ATTENTION]: Restoring shell proces for #<buffer S-bin> buffer

[khtan]

Hello, sorry I am not a developer and cannot do much. Just a ping to see if the information revealed anything? Thanks

[Bad-ptr]

Maybe it is somehow related to Windows or Spacemacs, or both.
I just tried it with my config on Linux and it works.
Sorry, I can not test it with spacemacs on windows.