Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested these exact commits yet, although I've made the same changes elsewhere in the past.
These three commits:
set_mean
is never called,channel_order
andinput_scale
so that pathological input behaves closer to expectation.Expanding on the last point in particular:
input_scale
to zero is the same as settinginput_scale
to one, due to the checkif input_scale
. Allowing the multiplication/division by zero properly breaks things or produces warnings.channel_order
to()
or0
is the same as setting it to the identity, due to the checkif channel_order
. Note that both of these are valid indices in numpy, although actually using them in this context is probably a mistake. Allowing the indexing will make such usages crash in most cases, instead of continuing as if the input were valid.