-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile a binary to run all tests at once. #179
Conversation
Some users may still want to run the runtest target in the old way. By "adds a new make target for a test_all.testbin" you might mean to do something as follows.
|
I'm not against keeping the old |
I think running all the tests with a full report is the right test target, and While in the development loop, if a particular test is failing it could be re-run alone by filtering as Eric suggests. To that end, the |
@erictzeng see development.md added in 857c6ac. |
Good to know the --gtest-filter flag - I didn't know that and went for the (hacky) separation. This seems a much nicer solution. |
I used to run the tests for the feature in development with "build/src/caffe/test/test_feature.testbin". Of course the flag is much more flexible. |
Hey @erictzeng, how about committing a sentence or two explaining how to run tests and filter them to docs/development.md and we'll merge? Thanks! |
Requested documentation has been added. |
Check this: CommonTest.TestBrewMode fails. |
Ah, this was due to a test assuming that Caffe would start in CPU mode. It fails when the test before it switches Caffe to GPU mode. I changed that test to explicitly set CPU mode before running, and a cursory glance at the remaining tests indicates that they are more explicit in setting Caffe's mode, but we should ensure future tests don't make any assumptions of this sort. |
Run all tests jointly in a single binary and summarize failures at the end.
Thanks @erictzeng! |
Run all tests jointly in a single binary and summarize failures at the end.
Hot fix preventing dead lock during shutdown
Fixes #174.
This pull requests adds a new make target for a
test_all.testbin
. Running this binary will run all tests. This is preferable to the current for-loop method of running each binary individually, since it will report a single summary once all tests complete.This required a few minor changes to the test_caffe_main header.
I am by no means a Makefile expert, so I am very much open to comments on my Makefile edits.