Clean up pycaffe internals #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will not actually support double nets in Python with this commit, but this change will be necessary to create layers that embed Python.
This brings pycaffe more in line with usual C++ style, and will allow the wrapper classes to be used within caffe when embedding Python.
Attaching names to pycaffe Blobs and Layers isn't necessary anymore, since they are now accessed by name. This change brings PyBlob and PyLayer closer to their C++ counterparts, and makes it easier to pass around blobs without knowing their names, e.g., when embedding Python in a layer.
While this function should never be called in the current interface, it will be necessary to have when embedding Python.
|
Sounds interesting. Are you developing a Torch7-like interface? |
|
👍 on 88221c9 and the Python layer project. Will review + merge soon. |
|
Thanks Jon! Can't wait for your sweet incoming PRs. |
This was referenced Sep 1, 2014
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Clean up pycaffe core
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Clean up pycaffe core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes no interface changes except for longjon@88221c9 (@shelhamer and others, let me know if that will cause any problems). It does bring pycaffe more in line with standard (and Google) C++ style.
More importantly, this PR makes it possible to use the
_caffemodule in C++ code that embeds the Python interpreter. This will enable a forthcoming PR (#1020).I'll let the commit log tell the rest.