Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math books sorting incorrectly in collection #223

Open
josieg opened this issue Feb 5, 2020 · 12 comments
Open

Math books sorting incorrectly in collection #223

josieg opened this issue Feb 5, 2020 · 12 comments

Comments

@josieg
Copy link

josieg commented Feb 5, 2020

Describe the bug
When I open the Adult Basic Education > Math category, there are a whole bunch of books listed that shouldn't be appearing there.

I checked a few of the books that are displaying incorrectly here (such as Brief Calculus and Business Math: A Step-by-Step Handbook, and all of those books have the correct categories selected in SOLR.)

To Reproduce
Steps to reproduce the behaviour:

  1. Go to the Open Textbook Collection.
  2. In the left subjects menu, click "Adult Basic Education" and then "Math"
  3. The collection will display 101 results (there should be less than 5)
@josieg
Copy link
Author

josieg commented Feb 5, 2020

Same thing also seems to be happening to the Business > Entrepreneurship category

@alex-418
Copy link
Contributor

alex-418 commented Feb 5, 2020

Summary of investigation and conversation so far with @josieg:

  • Checked the back-end for any issues with taxonomy, no issues found
  • Checked individual books to ensure they are not in the wrong taxonomy, no issues found

Next steps:
Figure out what is unique about the 101 results that appear in the ABE "Math" category, and if there's a bug with the logic generating the menu.

@josieg
Copy link
Author

josieg commented Feb 5, 2020

I just noticed that if you just type in "Math" into the collection search, you get the same 101 books.

@alex-418
Copy link
Contributor

alex-418 commented Feb 6, 2020

Hi Josie, this appears to be resolved. Can you please confirm?

@josieg
Copy link
Author

josieg commented Feb 6, 2020

Yep, can confirm...

@alex-418 alex-418 closed this as completed Feb 6, 2020
@josieg
Copy link
Author

josieg commented Feb 10, 2020

Hi Alex, this is happening again but with different categories.

See Social Sciences > Sociology (https://open.bccampus.ca/browse-our-collection/find-open-textbooks/?subject=Sociology)

Also, there is a Physics subcategory showing under Education?

@alex-418
Copy link
Contributor

@josieg Very interesting, I will look into this further. Can you think of anything that has changed recently. For example, any new characters or changes we made to categories? I will try to confirm if we're getting duplicates back from Equella, or if it's how we're parsing the data that's causing the issue.

@alex-418 alex-418 reopened this Feb 10, 2020
@josieg
Copy link
Author

josieg commented Feb 11, 2020

FYI the Sociology category is displaying the correct books again. But Physics is still showing up under "Education."

These are all of the changes we've requested be made to the collection categories in 2020.

They include adding the following new sub categories:

  • Computer Science > Computer Science - General
  • Earth and Ocean Sciences > Ocean Studies
  • Adult Basic Education > Science

And we also put in a request to change the "Creative Non-Fiction" sub-category to "Creative Writing"

@alex-418
Copy link
Contributor

Thanks @josieg I've resolved the Physics menu item showing up in the incorrect category. Glad to hear the Sociology category is displaying the correct books again. I'm not entirely sure why this happened.

@dshaykewich
Copy link
Collaborator

Krista noticed the same error with ABE->Math. Captured here:
https://jira.bccampus.ca/browse/BOIS-52

@dshaykewich
Copy link
Collaborator

@josieg , how many results should come back in the Chemistry category? I'm currently seeing 61.
https://open.bccampus.ca/browse-our-collection/find-open-textbooks/?subject=Chemistry

@josieg
Copy link
Author

josieg commented Mar 9, 2020

It's showing me 7 now, which should be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants