-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update docs and tutorials to 2.0 #321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .pre-commit-config.yaml # environment.yml # pyproject.toml
# Conflicts: # src/facet/validation/_validation.py
DOC: finalize API documentation for 2.0 release
* API: move simulation base classes to new module facet.simulation.base * REFACTOR: remove an obsolete 'if' clause * REFACTOR: declare constant for repetitive string literal * FIX: change a type hint from List to Sequence * DOC: remove an obsolete comment * REFACTOR: declare constants for repetitive string literals * REFACTOR: clarified comments and variable names * REFACTOR: de-complexify Sample.__init__ * REFACTOR: remove an unused variable * REFACTOR: disambiguate a regular expression * REFACTOR: merge a nested 'if' expression * REFACTOR: improve comments * REFACTOR: simplify CSS * REFACTOR: un-bracket alternatives in regular expression * TEST: remove unused fixtures from test method arguments * TEST: remove an obsolete to-do * TEST: anonymize unused loop variables * TEST: add constants for recurring exception messages * TEST: minor code tweaks
# Conflicts: # src/facet/data/_sample.py
# Conflicts: # src/facet/data/_sample.py # src/facet/inspection/_explainer.py # src/facet/inspection/_shap_global_explanation.py
…d_tutorials_to_2.0
# Conflicts: # sphinx/source/contribution_guide.rst
j-ittner
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @j-ittner!
In this PR I will submit all updated tutorials and docs, here's todo list:
Classification Tutorial: Prediabetes
updateDiabetes getting stared
updateIntroductory Tutorial: Incident risk of drilling operations
updateGenerating Standard Scikit-learn Classifier Performance Summaries
updateSequential PR: Need to merge #317 first.