Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted ecmp HLD #738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

caizhenghui-juniper
Copy link

No description provided.

@ghost
Copy link

ghost commented Jan 20, 2021

CLA assistant check
All CLA requirements met.

@caizhenghui-juniper caizhenghui-juniper changed the title Add initial design for weighted ecmp HLD Weighted ecmp HLD Jan 20, 2021

#### Unit Test cases

#### System Test cases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please describe system test cases.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add:
set up ECMP route with weight through config_db static_route table(e.g. two routes in NHG with weight of 2,8).
Send traffic with enough tuple variations and observe traffic load unevenly distributed on the two routes in the NHG as (20% and 80%).

* @flags CREATE_AND_SET
* @default 1
*/
SAI_NEXT_HOP_GROUP_MEMBER_ATTR_WEIGHT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the sai does not support this attribute, what would be the system behavior?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When vendor's SAI don't support, it will be ECMP vs WECMP.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check when SAI is supported and handling it accordingly.

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@yxieca yxieca force-pushed the master branch 2 times, most recently from 8498931 to 8837dc2 Compare April 15, 2022 16:51
@zhangyanzhao
Copy link
Collaborator

sonic-net/sonic-swss#1752 code PR.

@zhangyanzhao
Copy link
Collaborator

@caizhenghui-juniper can you please help to sign the EasyCLA? Thanks.

@nazariig
Copy link
Collaborator

nazariig commented May 2, 2024

@zhangyanzhao code PR is merged. Any reason not to merge HLD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants