Update sflow_hld.md with pkt drop notifications support #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update sflow_hld.md with pkt drop notifications support
|
@zhangyanzhao I have shared the HLD for wider community review. however, the HLD feature has dependencies with SAI vendors support from Marvel, EC, BRCM and Nvidia. So far I didn't receive any commitments from the vendors yet. IMHO we should defer this feature for upcoming release. |
|
Do it have any other CLI command to setup the sflow for drop reason or profile can associate with drop notification ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sflow_hld.md with pkt drop notifications support