Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dhcpv6 options and performance #1109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kellyyeh
Copy link
Contributor

@kellyyeh kellyyeh commented Oct 30, 2022

Add interface-id option, update yang model, config update
Update performance with typical vlan usage

```
Restart dhcp_relay after updating ipv6 helper information.

**only DHCP_RELAY table needs to be updated for the latest versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please specify what do you mean by latest version?


Usage:
```
redis-cli -n 4 hset DHCP_RELAY|<vlan> dhcpv6_option|rfc6939_support <true/false>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using redis-cli is not a standard way of configuring SONiC. It should be done through config load of json when click CLI is not available. Please update the documentation to have all configuration examples using json format and mention it can be used with config load command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a json example of the config to be put it.

Eg:

{
        "DHCP_RELAY" :{
                "Vlan100" : {
                        "dhcpv6_servers" : ["fc02:2000::2"]
                }
        }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is still applicable

yxieca
yxieca previously approved these changes Nov 29, 2022
@yxieca yxieca self-requested a review November 29, 2022 17:48

Usage:
```
redis-cli -n 4 hset DHCP_RELAY|<vlan> dhcpv6_option|rfc6939_support <true/false>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a json example of the config to be put it.

Eg:

{
        "DHCP_RELAY" :{
                "Vlan100" : {
                        "dhcpv6_servers" : ["fc02:2000::2"]
                }
        }
}

# Config Update

We have shifted from VLAN table to DHCP_RELAY table to store ipv6 helper information.
Only DHCP_RELAY table needs to be updated for the versions containing PR https://github.com/sonic-net/sonic-buildimage/pull/10654, or version 20201231.75 and 20181130.98 and above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include this PR sonic-net/sonic-buildimage#13006 and those versions might not work completely as suggested in the description of the PR

type bool;
}

leaf dhcpv6_option|interface_id {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will be a future change


Usage:
```
redis-cli -n 4 hset DHCP_RELAY|<vlan> dhcpv6_option|rfc6939_support <true/false>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is still applicable

Typical number of vlans used with dhcp6relay is around 2 vlans. Performance degration and high CPU utilization is seen on devices with more than 25 vlans configured, especially devices with weaker CPU's.
Tests have shown functionality and performance degradation when there are more than 20 vlans configured on weaker CPU's.

• 25 Vlans - Passed on SPC1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Vendor specific information like SPC1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants