Update main.py #960
Open
Update main.py #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'state == ok ' was no longer supported now.
prsunny
reviewed
Jun 24, 2020
| @@ -2214,7 +2214,7 @@ def bind(ctx, interface_name, vrf_name): | |||
| state_db = SonicV2Connector(host='127.0.0.1') | |||
| state_db.connect(state_db.STATE_DB, False) | |||
| _hash = '{}{}'.format('INTERFACE_TABLE|', interface_name) | |||
| while state_db.get(state_db.STATE_DB, _hash, "state") == "ok": | |||
| while state_db.get_all(state_db.STATE_DB, _hash) != None: | |||
There was a problem hiding this comment.
Not sure I understand this change. Why do you say it is no longer supported? Is there any PR that you can point which resulted in this?
There was a problem hiding this comment.
For example：
We have Vrf10 and Ethernet10 with 10.10.10.10.
using commands "sudo config interface bind Ethernet10 Vrf10" will lead to an error: There is no "master Vrf10" when use command "ip a show Ethernet10" to check its master.
jleveque
suggested changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'state == ok ' was no longer supported now.
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)