fix show acl table exception #2359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft could you please review, thanks. |
|
@qiluo-msft @prsunny could you please review, thanks. |
qiluo-msft
reviewed
Oct 10, 2022
qiluo-msft
reviewed
Oct 10, 2022
qiluo-msft
reviewed
Oct 11, 2022
qiluo-msft
reviewed
Oct 11, 2022
pettershao-ragilenetworks
requested review from
qiluo-msft
and removed request for
bingwang-ms
|
@qiluo-msft @bingwang-ms please review again， thanks |
|
@qiluo-msft @bingwang-ms could you please review and merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix KeyError exception for show acl table
root@sonic:/home/admin# config acl add table test CTRLPLANE
root@sonic:/home/admin# show acl table
Traceback (most recent call last):
File "/usr/local/bin/acl-loader", line 8, in
sys.exit(cli())
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/acl_loader/main.py", line 967, in table
acl_loader.show_table(table_name)
File "/usr/local/lib/python3.9/dist-packages/acl_loader/main.py", line 798, in show_table
services = natsorted(val["services"])
KeyError: 'services'
root@sonic:/home/admin#
How I did it
Check if value is empty
How to verify it
Run test
Previous command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# show acl table
Traceback (most recent call last):
File "/usr/local/bin/acl-loader", line 8, in
sys.exit(cli())
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/acl_loader/main.py", line 967, in table
acl_loader.show_table(table_name)
File "/usr/local/lib/python3.9/dist-packages/acl_loader/main.py", line 798, in show_table
services = natsorted(val["services"])
KeyError: 'services'
New command output (if the output of a command-line utility has changed)