[BFN] Added support for tofino3 profiles naming #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrx-kolomeiets
previously approved these changes
May 5, 2022
akokhan
previously approved these changes
May 5, 2022
taras-keryk
dismissed stale reviews from akokhan and oleksandrx-kolomeiets
via
831208f
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
d74617f
to
831208f
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
9 times, most recently
from
878707c
to
b97a299
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
dfb5e81
to
d40555c
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
d40555c
to
5c6c2a3
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
4 times, most recently
from
713a9ca
to
8fa6adc
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
32c5c89
to
8b9f414
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
4 times, most recently
from
5dccfe8
to
14da5ab
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
3 times, most recently
from
ff47f67
to
4831a8e
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
5 times, most recently
from
db50151
to
9b3189e
Compare
taras-keryk
requested review from
oleksandrx-kolomeiets and
akokhan
and removed request for
oleksandrx-kolomeiets and
akokhan
akokhan
reviewed
Jan 10, 2023
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
9b3189e
to
b1fc78f
Compare
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
b1fc78f
to
1fd2c8b
Compare
oleksandrx-kolomeiets
previously approved these changes
Jan 11, 2023
akokhan
reviewed
Jan 16, 2023
taras-keryk
force-pushed
the
tk_tof3_prof_nam_bf
branch
from
48facca
to
48055b0
Compare
oleksandrx-kolomeiets
approved these changes
Jan 19, 2023
akokhan
approved these changes
Jan 19, 2023
|
@qiluo-msft could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for tofino3 P4 profiles naming.
How I did it
Changed P4 profile naming format for support new tofino3 profiles. Added backward compatibility support for previous profile naming format.
How to verify it
The next commands should correctly work with the old and new profile naming format
and
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)