-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aclshow] enhance ACL counters to work with FC infrastructure #1858
Conversation
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@bingwang-ms could you please help review? |
@bingwang-ms could you please help to review? |
Can you please paste some example output? Thanks |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe you are missing the command reference guide md file update with the new CLI.
@liat-grozovik There is no new CLI but there are new commands in existing "counterpoll" which is not in Command-Reference.md at all. So I considered that as a different effort to document counterpoll with all it's existing commands. |
What I did
Made a change for aclshow and counterpoll that adds support for ACL flex counters.
DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953 sonic-net/sonic-swss#1943
HLD: sonic-net/SONiC#857
How I did it
Modified aclshow and counterpoll and UT.
How to verify it
Together with depends PRs. Run ACL/Everflow test suite.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)