[show] Allow system with no ports in config db run without errors #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liora <liora@nvidia.com>
|
please provide previous and new output as mentioned in the template |
dgsudharsan
reviewed
Jul 7, 2021
utilities_common/cli.py
Outdated
| @@ -125,8 +125,7 @@ def __init__(self, db=None): | |||
| self.port_dict = self.config_db.get_table('PORT') | |||
| self.alias_max_length = 0 | |||
|
|
|||
|
|
|||
| if not self.port_dict: | |||
| if self.port_dict is None: | |||
There was a problem hiding this comment.
If the get_table API doesn't return None, this check may not be needed and we can remove it altogether. Can you please confirm?
There was a problem hiding this comment.
I agree. Both get_table() and get_port_table() initialize an empty dictionary which is being returned even if 'PORT' table is empty. I removed this check.
Signed-off-by: liora <liora@nvidia.com>
|
Is this the only change needed for empty port config in the show commands? Or this is just enough to allow system to come up? |
|
@caizhenghui-juniper |
|
@prsunny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allow system with no ports in config db run without errors.
This is needed for modular system which should boot properly without line cards.
How I did it
Do not raise warning if ports dictionary is empty.
How to verify it
Run show interfaces status
Previous command output (if the output of a command-line utility has changed)
root@r-leopard-41:/home/admin# show interfaces status
Warning: failed to retrieve PORT table from ConfigDB!
Warning: failed to retrieve PORT table from ConfigDB!
Interface Lanes Speed MTU FEC Alias Vlan Oper Admin Type Asym PFC
*----------- ------- ------- ----- ----- ------- ------ ------ ------- ------ ----------
root@r-leopard-41:/home/admin#
New command output (if the output of a command-line utility has changed)
root@r-leopard-41:/home/admin# show interfaces status
Interface Lanes Speed MTU FEC Alias Vlan Oper Admin Type Asym PFC
*----------- ------- ------- ----- ----- ------- ------ ------ ------- ------ ----------
root@r-leopard-41:/home/admin#