Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPB] fix optional fields for child ports in scope DPB #1492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmytroxshevchuk
Copy link
Contributor

@dmytroxshevchuk dmytroxshevchuk commented Mar 11, 2021

As part of PR:
sonic-net/sonic-buildimage#6660

What I did

After DPB cli command, optional fields 'fec' has N/A state
Before DPB:

  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
 Ethernet32      32,33,34,35     100G   9100     rs   Ethernet32  routed      up       up  QSFP28 or later         N/A

After DPB:

  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
 Ethernet32            32,33      50G   9100    N/A   Ethernet32  routed    down       up  QSFP28 or later         N/A
 Ethernet34            34,35      50G   9100    N/A   Ethernet34  routed    down       up              N/A         N/A

Expect that, fields from parent ports must be produced in child ports.

How I did it

How to verify it

Execute: sudo config interface breakout Ethernet0 2x50G -f

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@dmytroxshevchuk dmytroxshevchuk changed the title [DPB] fix optional fields for child ports in scope DPB WIP: [DPB] fix optional fields for child ports in scope DPB Mar 11, 2021
@dmytroxshevchuk dmytroxshevchuk changed the title WIP: [DPB] fix optional fields for child ports in scope DPB [DPB] fix optional fields for child ports in scope DPB Mar 12, 2021
@allas-nvidia
Copy link
Contributor

Can someone take a look, please?
Thanks

Copy link
Collaborator

@zhenggen-xu zhenggen-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redesign needed for sonic-net/sonic-buildimage#6660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants