Add parameter "-S/--services" for ACL CLI to create service ACL table. #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- What I did Add parameter "-v/--services" in ACL CLI. Syntax for ACL * config acl add table <table_name> <table_type> [(-d | --description) <description>] [(-p | --ports) <interfaces>] [(-s | --stage) (ingress | egress)] [(-v | --services) <services_string>] - Why I did it User cannot create CTRLPLANE ACL table which with "services" information. Creating CTRLACL table without services information through CLI will cause dut crash. - How I verified it User can create CTRLPLANE ACL table that has dut work normally through CLI. - Details if related Signed-off-by: Fred Yu fred_yu@edge-core.com
|
This pull request introduces 1 alert when merging 759002e into 28d358f - view on LGTM.com new alerts:
|
fredyu190011
changed the title
|
I have already fixed the conflict, please review it. |
|
This pull request introduces 1 alert when merging 52d7013 into 08337aa - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c2771cc into 08337aa - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add parameter "-S/--services" in ACL CLI.
Syntax for ACL
- How I did it
User cannot create CTRLPLANE ACL table which with "services" information.
Creating CTRLACL table without services information through CLI will cause dut crash.
- How to verify it
User can create CTRLPLANE ACL table that has dut work normally through CLI.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
- Details if related
Signed-off-by: Fred Yu fred_yu@edge-core.com