[MultiDB] add MultiDB warmboot support - backing up database #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft These two PRs are for multiDB warmboot support as proposed earlier. |
qiluo-msft
reviewed
Nov 10, 2020
scripts/migrate_warmboot_database
Outdated
| args = parser.parse_args() | ||
|
|
||
| if args.target_db: | ||
| try: |
There was a problem hiding this comment.
[](start = 0, length = 12)
too much indentation. #Closed
qiluo-msft
reviewed
Nov 10, 2020
scripts/fast-reboot
Outdated
| docker exec -i database rm /var/lib/redis/$REDIS_FILE | ||
|
|
||
| # move all db data into instances where APPL_DB locates | ||
| migrate_warmboot_database APPL_DB |
There was a problem hiding this comment.
migrate_warmboot_database [](start = 4, length = 25)
The name is misleading. It is not directly related to warmboot.
Suggestion centralize_database
#Closed
qiluo-msft
reviewed
Nov 10, 2020
scripts/migrate_warmboot_database
Outdated
| dbport = swsssdk.SonicDBConfig.get_port(dbname) | ||
| # if the db is on the same instance, no need to migrate | ||
| if dbport == target_dbport: | ||
| continue |
There was a problem hiding this comment.
Is it enough to determine "the same instance" ? #Closed
There was a problem hiding this comment.
good catch. hostname plus port is enough to determine the "unique instance" . Updated
qiluo-msft
reviewed
Nov 10, 2020
scripts/fast-reboot
Outdated
| # move all db data into instances where APPL_DB locates | ||
| migrate_warmboot_database APPL_DB | ||
|
|
||
| inst=`/usr/bin/python -c "import swsssdk; print(swsssdk.SonicDBConfig.get_instancename('APPL_DB'))"` |
There was a problem hiding this comment.
inst [](start = 4, length = 4)
Instead of using a new process to locate APPL_DB, you may just print it to stdout in above command. #Closed
qiluo-msft
approved these changes
Nov 19, 2020
yxieca
approved these changes
Dec 3, 2020
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 10, 2020
* restoring each database with all data before warmboot and then flush unused data in each instance, following the multiDB warmboot design at https://github.com/Azure/SONiC/blob/master/doc/database/multi_database_instances.md * restore needs to be done in database docker since we need to know the database_config.json in new version * copy all data rdb file into each instance restoration location andthen flush unused database * other logic is the same as before * backing up database part is in another PR at sonic-utilities sonic-net/sonic-utilities#1205, they depend on each other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com