[reload] Improve reload by using sonic.target. #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Telemetry test case is no longer valid scenario to unit test. Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
This was referenced Oct 28, 2020
|
This pull request introduces 1 alert when merging 6b63721 into 1753f22 - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
retest this please |
yxieca
previously approved these changes
Nov 10, 2020
|
This PR depends on sonic-net/sonic-buildimage#5705 |
…_enhancement Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
…_enhancement Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
rajendra-dendukuri
previously approved these changes
Jan 15, 2021
…_enhancement Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
@rajendra-dendukuri I've just merged master and resolved conflict, could you please approve? |
|
@yxieca Could you please review after merges from master? |
yxieca
previously approved these changes
Jan 24, 2021
|
retest this please |
1 similar comment
|
retest this please |
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
yxieca
previously approved these changes
Feb 2, 2021
|
@rajendra-dendukuri and yxieca can you please review again? |
rajendra-dendukuri
approved these changes
Feb 18, 2021
|
@yxieca as it was approved before and we lost you r approval with the recent merge, can you please review and approve so we can move forward with merging it? |
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
yxieca
approved these changes
Mar 1, 2021
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
- What I did To remove the list of hardcoded order-dependent lists of services to stop/restart/reset-failed. - How I did it Used sonic.target to stop/restart/reset-failed. - How to verify it Execute config reload and observe the services do restart. Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 4, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
@stepanblyschak should we label it for 202012 as well? sonic.target is expected to be included in 202012 if i remember correct. |
|
@liat-grozovik yes, it looks like we want this feature in 202012 and this PR is crucial part of it. |
|
@stepanblyschak @liat-grozovik there is a merge conflict when cherry-picking, please open a PR against 202012 branch |
|
included in 202012 via #1509 |
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
lolyu
pushed a commit
to lolyu/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyshchak stepanb@nvidia.com
- What I did
To remove the list of hardcoded order-dependent lists of services to stop/restart/reset-failed.
- How I did it
Used sonic.target to stop/restart/reset-failed.
- How to verify it
Execute config reload and observe the services do restart.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)