Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consutil] Fix issue where the show line command crash if no ttyUSB exists #1173

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Oct 14, 2020

- What I did

Address this issue: #1172
The show line command crashed with ls command error if current device doesn't have ttyUSB device under \dev

- How I did it

Reverse the control of run_command function which enable the function user can decide if exit current context.

- How to verify it

Build python-wheel package and tested it on a physical DUT.

- Previous command output (if the output of a command-line utility has changed)

Command resulted in error: ls: cannot access '/dev/ttyUSB*': No such file or directory

- New command output (if the output of a command-line utility has changed)

  Line    Baud    PID    Start Time    Device
------  ------  -----  ------------  --------
     1  115000                        switch1
     2    9600                              -

@Blueve Blueve requested a review from yxieca October 14, 2020 09:19
@Blueve Blueve added the Bug label Oct 14, 2020
@Blueve Blueve merged commit e51d44f into sonic-net:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants