Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[celestica] consutil to support customize tty device name #1155

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

sandycelestica
Copy link
Contributor

- What I did
Change the DEVICE_PREFIX if customer wants to rename the ttyUSB devices

- How I did it
Get the DEVICE_PREFIX from "udevprefix.conf" which has been generated when udev rules been detected.

- How to verify it
To verify it better cowork with the udev rules.Details can refer to https://github.com/Azure/SONiC/pull/654/files

Copy link
Contributor

@Blueve Blueve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just a few comments.

consutil/lib.py Outdated Show resolved Hide resolved
consutil/lib.py Outdated Show resolved Hide resolved
consutil/lib.py Outdated Show resolved Hide resolved
consutil/lib.py Outdated Show resolved Hide resolved
keep the code format align see add spaces for special symbols
@Blueve Blueve requested a review from yxieca October 10, 2020 03:42
@Blueve
Copy link
Contributor

Blueve commented Oct 13, 2020

retest default please

@sandycelestica sandycelestica changed the title Update lib.py [celestica] consutil to support customize tty device name Oct 13, 2020
@Blueve Blueve merged commit 3a7457c into sonic-net:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants