[consutil] Remove actual baud and refactor lib for future change #1130
Conversation
| pid, _ = busyDevices[linenum] | ||
| busyLines = getBusyLines() | ||
| if lineNumber in busyLines: | ||
| pid, _ = busyLines[lineNumber] | ||
| cmd = "sudo kill -SIGTERM " + pid |
There was a problem hiding this comment.
I am wondering if we need to add some more check there before sending that kill signal.
What if we have a pid logged in db but somehow process quit didn't clear the db. However, some critical process took the PID. Blindly sending the kill could be dangerous. @jleveque what do you think?
There was a problem hiding this comment.
This comments doesn't block this PR. If change needed, the change can come with a separate PR.
There was a problem hiding this comment.
@yxieca: Adding a check to ensure the PID is still assigned to the expected process is probably a good idea to add in a future PR. It definitely wouldn't hurt.
There was a problem hiding this comment.
Yes, totally agree.
Currently, it is safe to clear it by the PID because the PID were extract from PS command.
The check will be necessary after I introduced STATE_DB.
I will add checks in future PR. Thanks for comments
- What I did
consutil showresult tableERR_CFGfor indicating configuration issue- How I did it
ERR_CFGas the bad/missing configuration caused return code- How to verify it
Build a deb and test it on a physical DUT with following CONSOLE_PORT configuration:
- Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ sudo consutil show Line Actual/Configured Baud PID Start Time Device ------ ------------------------ ----- ------------ -------- 0 9600/- - 1 9600/9600 switch1 2 9600/- - 3 9600/- - 4 9600/- - 5 9600/- - 6 9600/- - 7 9600/- - 8 9600/- - 9 9600/- - 10 9600/- - 11 9600/- - 12 9600/- - 13 9600/- - 14 9600/- - 15 9600/- - 16 9600/- - 17 9600/- - 18 9600/- - 19 9600/- - 20 9600/- - 21 9600/- - 22 9600/- - 23 9600/- - 24 9600/- - 25 9600/- - 26 9600/- - 27 9600/- - 28 9600/- - 29 9600/- - 30 9600/- - 31 9600/- - 32 9600/- - 33 9600/- - 34 9600/- - 35 9600/- - 36 9600/- - 37 9600/- - 38 9600/- - 39 9600/- - 40 9600/- - 41 9600/- - 42 9600/- - 43 9600/- - 44 9600/- - 45 9600/- - 46 9600/- - 47 9600/- -- New command output (if the output of a command-line utility has changed)
admin@sonic:~$ sudo consutil show Line Baud PID Start Time Device ------ ------ ----- ------------ -------- 0 - - 1 9600 switch1 2 - - 3 - - 4 - - 5 - - 6 - - 7 - - 8 - - 9 - - 10 - - 11 - - 12 - - 13 - - 14 - - 15 - - 16 - - 17 - - 18 - - 19 - - 20 - - 21 - - 22 - - 23 - - 24 - - 25 - - 26 - - 27 - - 28 - - 29 - - 30 - - 31 - - 32 - - 33 - - 34 - - 35 - - 36 - - 37 - - 38 - - 39 - - 40 - - 41 - - 42 - - 43 - - 44 - - 45 - - 46 - - 47 - -