show interface portchannel support for Multi ASIC #1005

arlakshm · 2020-07-24T23:42:55Z

Add the multi ASIC specific options for the command show interface portchannel

Depends on the following PRs

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com

- What I did
Add support for multi ASIC CLI options for show interface portchannels
2 new options have added

[-n, --namespace] to allow user to display the information for given namespaces
If this option is not present the information from all the namespaces will be displayed
[-d, --display] to allow user to display information related both internal and external interfaces
If this option is not present only external interfaces/neighbors will be display

One single ASIC platform, this options are not valid, so the behavior remains unchanged

- How I did it

Change the teamshow script to get the port channel information from all the Namespaces
Add support for -n and -d options
This new options are ignored for single ASIC platforms

- How to verify it
Help menu on multi ASIC platforms


admin@sonic:~$ show interface portchannel -h
Usage: show interface portchannel [OPTIONS]

  Show PortChannel information

Options:
  -d, --display [all|frontend]    Show internal interfacees  [default:
                                  frontend]
  -n, --namespace [asic0|asic1|asic2|asic3|asic4|asic5]
                                  Namespace name or all
  --verbose                       Enable verbose output
  -?, -h, --help                  Show this message and exit.
admin@sonic:~$

Sample output for show interface portchannel

admin@sonic:~$ show interface portchannel 
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev         Protocol     Ports
-----  ---------------  -----------  -----------------------------------------------------------------------------------------------------------------------------------------------
 1001  PortChannel1001  LACP(A)(Up)  Ethernet136(S)
 1002  PortChannel1002  LACP(A)(Up)  Ethernet0(S) Ethernet4(S)
 1003  PortChannel1003  LACP(A)(Up)  Ethernet144(S)
 1004  PortChannel1004  LACP(A)(Up)  Ethernet148(S)
 1005  PortChannel1005  LACP(A)(Up)  Ethernet20(S) Ethernet16(S)
 1006  PortChannel1006  LACP(A)(Up)  Ethernet152(S)
 1007  PortChannel1007  LACP(A)(Up)  Ethernet156(S)
 1008  PortChannel1008  LACP(A)(Up)  Ethernet64(S) Ethernet68(S)
 1009  PortChannel1009  LACP(A)(Up)  Ethernet168(S)
 1010  PortChannel1010  LACP(A)(Up)  Ethernet176(S)
 1011  PortChannel1011  LACP(A)(Up)  Ethernet80(S) Ethernet84(S)
 1012  PortChannel1012  LACP(A)(Up)  Ethernet180(S)
 1013  PortChannel1013  LACP(A)(Up)  Ethernet184(S)
 1014  PortChannel1014  LACP(A)(Up)  Ethernet188(S)
 1015  PortChannel1015  LACP(A)(Up)  Ethernet200(S)
 1016  PortChannel1016  LACP(A)(Up)  Ethernet208(S)
 1017  PortChannel1017  LACP(A)(Up)  Ethernet212(S)
 1018  PortChannel1018  LACP(A)(Up)  Ethernet216(S)
 1019  PortChannel1019  LACP(A)(Up)  Ethernet220(S)
 1020  PortChannel1020  LACP(A)(Up)  Ethernet232(S)
 1021  PortChannel1021  LACP(A)(Up)  Ethernet240(S)
 1022  PortChannel1022  LACP(A)(Up)  Ethernet244(S)
 1023  PortChannel1023  LACP(A)(Up)  Ethernet248(S)
 1024  PortChannel1024  LACP(A)(Up)  Ethernet252(S)

**Sample output for single ASIC **

admin@sonic:~$ show interface portchannel -n asic0
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev         Protocol     Ports
-----  ---------------  -----------  ---------------------------
 1002  PortChannel1002  LACP(A)(Up)  Ethernet0(S) Ethernet4(S)
 1005  PortChannel1005  LACP(A)(Up)  Ethernet20(S) Ethernet16(S)


admin@sonic:~$ show interface portchannel -n asic0 -d all
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev         Protocol     Ports
-----  ---------------  -----------  ---------------------------------------------------------------------------------------------------------------------------------------
 1002  PortChannel1002  LACP(A)(Up)  Ethernet0(S) Ethernet4(S)
 1005  PortChannel1005  LACP(A)(Up)  Ethernet20(S) Ethernet16(S)
 4001  PortChannel4001  LACP(A)(Up)  Ethernet-BP4(S) Ethernet-BP16(S) Ethernet-BP20(S) Ethernet-BP12(S) Ethernet-BP24(S) Ethernet-BP0(S) Ethernet-BP28(S) Ethernet-BP8(S)
 4002  PortChannel4002  LACP(A)(Up)  Ethernet-BP48(S) Ethernet-BP60(S) Ethernet-BP52(S) Ethernet-BP40(S) Ethernet-BP36(S) Ethernet-BP56(S) Ethernet-BP44(S) Ethernet-BP32(S)

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

lgtm-com · 2020-07-24T23:49:20Z

This pull request introduces 1 alert when merging e71321f into aa1b072 - view on LGTM.com

new alerts:

1 for Unused import

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

jleveque · 2020-07-30T23:56:00Z

Please note that the PR check build will fail until the following PRs are merged (in this order):

judyjoseph · 2020-08-05T21:03:16Z

show/main.py

@@ -1116,10 +1117,15 @@ def rif(interface, period, verbose):

 # 'portchannel' subcommand ("show interfaces portchannel")
 @interfaces.command()
+@multi_asic_click_options


For the config commands I add the namespace option at the command group level ( i.e if you take this example ..it will be like show interfaces -n asic0 portchannel/counters ) instead of specifying the options after the subcommand keyword viz portchannel, counters etc ..

I was looking to see if both the show and config commands follow similar approach .. @arlakshm @jleveque your thoughts ?

@judyjoseph. IMO the CLI syntax is cleaner if we have the keywords first then followed by options/arguments.

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

lgtm-com · 2020-08-18T17:25:25Z

This pull request introduces 2 alerts when merging a942c4b into 8768580 - view on LGTM.com

new alerts:

2 for Unused import

show/interfaces/portchannel.py

lguohan · 2020-08-21T06:27:47Z

please pass the test

lguohan · 2020-08-21T06:28:57Z

show/interfaces/portchannel.py

 @click.option('--verbose', is_flag=True, help="Enable verbose output")
-@clicommon.pass_db


why is this removed? this can break the unit test.

With multi asic support, Teamshow will connect to DBs in each namespace or default namespace. No need to pass the db. Unit test will work with the changes done to support multi asic CLIs

show/interfaces/portchannel.py

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

lgtm-com · 2020-08-21T16:17:57Z

This pull request introduces 2 alerts when merging 0eaaa72 into 2c0ff92 - view on LGTM.com

new alerts:

2 for Unused import

arlakshm · 2020-08-21T16:18:05Z

please pass the test

@lguohan, tests are passing now. There was dependency with PR #1006 for Unit tests to work.
Logs

[2020-08-21T16:11:55.162Z] ============================= test session starts ==============================
[2020-08-21T16:11:55.162Z] platform linux2 -- Python 2.7.16, pytest-3.10.1, py-1.7.0, pluggy-0.8.0
[2020-08-21T16:11:55.162Z] rootdir: /sonic/sonic-utilities, inifile: pytest.ini
[2020-08-21T16:11:55.162Z] plugins: cov-2.6.0
[2020-08-21T16:11:56.107Z] collected 138 items
[2020-08-21T16:11:56.107Z] 
[2020-08-21T16:11:56.626Z] tests/acl_loader_test.py ....                                            [  2%]
[2020-08-21T16:11:56.886Z] tests/aclshow_test.py ...........                                        [ 10%]
[2020-08-21T16:11:57.152Z] tests/config_mgmt_test.py ....                                           [ 13%]
[2020-08-21T16:11:57.412Z] tests/config_test.py ..                                                  [ 15%]
[2020-08-21T16:12:01.088Z] tests/drops_group_test.py .......                                        [ 20%]
[2020-08-21T16:12:01.347Z] tests/feature_test.py ..........                                         [ 27%]
[2020-08-21T16:12:01.347Z] tests/filter_fdb_entries_test.py ..........                              [ 34%]
[2020-08-21T16:12:02.482Z] tests/gearbox_test.py ..                                                 [ 36%]
[2020-08-21T16:12:02.998Z] tests/interfaces_test.py .............                                   [ 45%]
[2020-08-21T16:12:14.691Z] tests/intfstat_test.py ........                                          [ 51%]
[2020-08-21T16:12:23.281Z] tests/intfutil_test.py ...............                                   [ 62%]
[2020-08-21T16:12:27.836Z] tests/multi_asic_intfutil_test.py .........                              [ 68%]
[2020-08-21T16:12:27.836Z] tests/port2alias_test.py ....                                            [ 71%]
[2020-08-21T16:12:28.935Z] tests/psu_test.py ...                                                    [ 73%]
[2020-08-21T16:12:29.194Z] tests/sflow_test.py ..                                                   [ 75%]
[2020-08-21T16:12:31.468Z] tests/sfp_test.py ...                                                    [ 77%]
[2020-08-21T16:12:31.468Z] tests/show_breakout_test.py ..                                           [ 78%]
[2020-08-21T16:12:31.468Z] tests/show_platform_test.py .                                            [ 79%]
[2020-08-21T16:12:36.390Z] tests/vlan_test.py ............................                          [100%]

lguohan

approve with caveats. we need to allow to pass db into the commands for unit tests

show interface portchannel support for Multi ASIC

e71321f

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Minor change to use the new library

194b619

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm requested review from jleveque, lguohan and smaheshm July 30, 2020 23:02

judyjoseph reviewed Aug 5, 2020

View reviewed changes

arlakshm added 2 commits August 17, 2020 14:38

Merge remote-tracking branch 'arlakshm/master' into masic_teamshow

b77f2ac

refactor to latest chnages

a942c4b

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

lguohan reviewed Aug 21, 2020

View reviewed changes

show/interfaces/portchannel.py Outdated Show resolved Hide resolved

lguohan reviewed Aug 21, 2020

View reviewed changes

show/interfaces/portchannel.py Show resolved Hide resolved

arlakshm added 2 commits August 21, 2020 08:56

Merge remote-tracking branch 'arlakshm/master' into masic_teamshow

9b8f365

Address review comments

0eaaa72

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm requested a review from lguohan August 21, 2020 16:18

lguohan approved these changes Aug 22, 2020

View reviewed changes

arlakshm merged commit 71c6d65 into sonic-net:master Aug 24, 2020

jleveque mentioned this pull request Sep 3, 2020

[sonic-utilities][sonic-py-common] Move logic to get port config file path to sonic-py-common and update sonic-utilities to comply sonic-net/sonic-buildimage#5264

Merged

stephenxs mentioned this pull request Sep 4, 2020

[submodule] Advance submodule head for sonic-utilities sonic-net/sonic-buildimage#5318

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show interface portchannel support for Multi ASIC #1005

show interface portchannel support for Multi ASIC #1005

arlakshm commented Jul 24, 2020

lgtm-com bot commented Jul 24, 2020

jleveque commented Jul 30, 2020 •

edited

Loading

judyjoseph Aug 5, 2020

arlakshm Aug 6, 2020

lgtm-com bot commented Aug 18, 2020

lguohan commented Aug 21, 2020

lguohan Aug 21, 2020

arlakshm Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

arlakshm commented Aug 21, 2020

lguohan left a comment

		@click.option('--verbose', is_flag=True, help="Enable verbose output")
		@clicommon.pass_db

show interface portchannel support for Multi ASIC #1005

show interface portchannel support for Multi ASIC #1005

Conversation

arlakshm commented Jul 24, 2020

lgtm-com bot commented Jul 24, 2020

jleveque commented Jul 30, 2020 • edited Loading

judyjoseph Aug 5, 2020

Choose a reason for hiding this comment

arlakshm Aug 6, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Aug 18, 2020

lguohan commented Aug 21, 2020

lguohan Aug 21, 2020

Choose a reason for hiding this comment

arlakshm Aug 21, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Aug 21, 2020

arlakshm commented Aug 21, 2020

lguohan left a comment

Choose a reason for hiding this comment

jleveque commented Jul 30, 2020 •

edited

Loading