Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Support gnmi set, add some testcases and fix some bugs #14

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

liuqu
Copy link

@liuqu liuqu commented Aug 23, 2018

The detail change list:

  1. Add option tlsDisable for testing
  2. Add glide to support golang package dependencies management
  3. Support gnmi set
  4. Support non_db path: version, ntp, bgp neighbor, rib num, interface rate
  5. Refactor the db_table path module
  6. Support the field with wildcard in virtual path, add testcase for vpath module

Liuqu and others added 30 commits August 22, 2018 08:24
- Move the code that get DB table/key/field from gNMI path to path.go
- Add testcase for path module
- Add permit path list for SET RPC, and add testcase to cover it
- Need to refactor path module to support non-path -> valide path
  in stream or periodic mode
@jipanyang
Copy link
Collaborator

I'm afraid you need to break them into smaller feature pieces, and provide necessary description and document update for each of them.

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@lguohan lguohan requested a review from jleveque August 27, 2018 21:57
@lguohan
Copy link
Contributor

lguohan commented Aug 30, 2018

agree with jipan, can you break this PR into different PRs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants