Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vxlamgr]: Change default return value to true in doTask() to avoid retry the unknown table request #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gord1306
Copy link
Contributor

What I did
[vxlamgr]: Change default return value to true in doTask() to avoid retry the unknown table request

Why I did it
If the default value is false, the request will be retied next time. But those cases which cause return value be false are unknown table request, I thought this kind of requests should only write LOG instead of doing retry

How I verified it
Send incorrect table name request to doTask for vxlanmgr.cpp

@prsunny
Copy link
Collaborator

prsunny commented May 15, 2019

Looks to be trivial. Its ok either way. ConfigDB validator is in progress where the expectation is swss only gets correct config.

@gord1306
Copy link
Contributor Author

@prsunny, I saw the Configuration validation be list in the community meeting minute. Have you opened any documents for the design spec now? In fact, I am trying to implement gtest unit test cases for vxlanorch and vxlanmgr, and if those validations are done before orchagent, I will consider whether to skip these kinds of test cases

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…sonic-clear nat statistics" command (sonic-net#892)

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
@prsunny prsunny self-requested a review as a code owner September 2, 2022 23:17
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants