Periodic flush record files instead of flushing them on std::endl. #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR comes together with sonic-net/sonic-sairedis#1241. Flushing a file is expensive (depending on the FS). The original code flush the file on every write. This PR changes to flush every second (or when the buffer is full). This will increase the performance but the downside is that when the program crashes, we might miss some logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Periodic flush record files instead of flushing them on std::endl.
Why I did it
For performance purposes. In our testing, this provides 8% end-to-end performance improvement.
How I verified it
Details if related