[warm-restart] Fix teamd container warm restart issue #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check the WARM_RESTART_ENABLE_TABLE for teamd when stopping the teamsyncd. If the teamd warm restart is enabled, skip cleaning the LAG resource
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1810 in repo Azure/sonic-swss |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…db (sonic-net#1810) With switch to swsscommon, the get operations return NULL ('') if there are no entries in any table. But the existing code for handling counters values in the case of absence of entries assumes that the get operations return 'None', which was the case with swsssdk. This was causing problem. For PG_WATERMARK_STAT_COUNTER SAI does not support SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES and SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES. So there are no objects in the counters db. With swsscommon, in the absence of objects, an empty string ('') is returned instead of 'None'. The code expecting 'None' tries to converts the empty string to integer and throws error. This is fixed by adding check for empty string in addition to 'None'. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix the warm restart function of the teamd container
Why I did it
Originally, after stopping the teamd container, it will try to temove the LAG ports. When orchagent receive the modification, it will encounter error for removing the LAG ports because there are AclTable on them.
The error will be like:
How I verified it
sudo config warm_restart enable teamdsudo systemctl restart teamdDetails if related
If the teamd warm restart is enabled, skip cleaning the LAG resource