Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ifIndex of based interface started in RFC1213 should be one #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RayWang910012
Copy link

@RayWang910012 RayWang910012 commented Mar 24, 2021

- What I did
remove "-1" in ifIndex return.
- How I did it

- How to verify it
$ snmpget -v2c -c public 10.250.0.184 IF-MIB::ifIndex.1
IF-MIB::ifIndex.1 = INTEGER: 0

- Description for the changelog
The description of ifIndex in RFC1213 is

"A unique value for each interface.
Its valueranges between 1 and the value of ifNumber.
The value for each interface must remain constant at
least from one re-initialization of the entity's
network management system to the next reinitialization."

The based interface started from 0 is illegal in RFC1213 defined boundary.
So I think it should not minus one at this place.

@ghost
Copy link

ghost commented Mar 31, 2021

CLA assistant check
All CLA requirements met.

"A unique value for each interface.
Its valueranges between 1 and the value of ifNumber.
The value for each interface must remain constant at
least from one re-initialization of the entity's
network management system to the next reinitialization."

The based interface started from 0 is illegal in RFC1213 defined boundary.
So I think it should not minus one at this place.
Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuvarnaMeenakshi
Copy link
Contributor

retest this please

Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, we need to discuss internally before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants