[ciscoSwitchQosMIB]: Remove invocation of update_data function in reinit_data #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinit_data. udpate_data and reinit_data will be invoked by periodic events. update_data need not be invoked by reinit_data again. Additional invocation of update_data can cause increase in running time on multi-asic platform causing Agentx socket connection to break. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
approved these changes
Sep 25, 2020
abdosi
approved these changes
Sep 28, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 28, 2020
…#161) reinit_data. udpate_data and reinit_data will be invoked by periodic events. update_data need not be invoked by reinit_data again. Additional invocation of update_data can cause increase in running time on multi-asic platform causing Agentx socket connection to break. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ciscoSwitchQosMIB]: Remove invocation of update_data function in reinit_data
function. udpate_data and reinit_data will be invoked by periodic
events. update_data need not be invoked by reinit_data again.
Additional invocation of update_data can cause increase in running time
on multi-asic platform causing Agentx socket connection to break.
Signed-off-by: SuvarnaMeenakshi sumeenak@microsoft.com
- What I did
Removed invocation of update_data function in reinit_data function.
udpate_data and reinit_data will be invoked by periodic events.
update_data need not be invoked by reinit_data again.
Additional invocation of update_data can cause increase in running time on multi-asic platform causing Agentx socket connection to break.
- How I did it
Remove update_data call in reinit_data().
- How to verify it
Verified the output of QosMIB 1.3.6.1.4.1.9.9.580.1.5.5.1.4 on multi-asic platform.
- Description for the changelog