Support multiple IP addresses in LLDPRemManAddrTable

[samaity]

Signed-off-by: Sangita Maity samaity@linkedin.com

LLDPRemManAddrTable now supports multiple IP address just like lldpLocManAddrTable.

- What I did
Currently, Error occurs when "lldp_rem_man_addr" field has a list of IP strings like below.

19) "lldp_rem_man_addr"
20) "10.0.1.1,2000:0:1::1"

Before the fix
was getting log message like below.
"May 20 21:34:42.691758 lnos-x1-a-csw05 INFO snmp#snmp-subagent [ax_interface] ERROR: Invalid mgmt IP 10.0.1.1,2000:0:1::1 ---- multiple IP Addresses

LLDPRemManAddrTable now supports multiple IP address just like lldpLocManAddrTable.

- How I did it
Used split method to separate multiple mgmt_ip, and write a string to redis database.
- How to verify it

no error log in Syslog.

successfully able to snmpwalk 1.0.8802.1.1.2.1.4.2 oid. However,

root@lnos-x1-a-csw05:/# snmpwalk -v2c -c public 127.0.0.1 1.0.8802.1.1.2.1.4.2
iso.0.8802.1.1.2.1.4.2.1.1.796102.1.8.1.4.10.0.1.1 = INTEGER: 1
iso.0.8802.1.1.2.1.4.2.1.1.796102.1.8.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.1 = INTEGER: 2
iso.0.8802.1.1.2.1.4.2.1.1.1148938.5.6.1.4.10.0.1.2 = INTEGER: 1
iso.0.8802.1.1.2.1.4.2.1.1.1148938.5.6.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.2 = INTEGER: 2
iso.0.8802.1.1.2.1.4.2.1.2.796102.1.8.1.4.10.0.1.1 = STRING: "0A 00 01 01"
iso.0.8802.1.1.2.1.4.2.1.2.796102.1.8.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.1 = STRING: "2000 0 1 0 1"
iso.0.8802.1.1.2.1.4.2.1.2.1148938.5.6.1.4.10.0.1.2 = STRING: "0A 00 01 02"
iso.0.8802.1.1.2.1.4.2.1.2.1148938.5.6.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.2 = STRING: "2000 0 1 0 2"
iso.0.8802.1.1.2.1.4.2.1.3.796102.1.8.1.4.10.0.1.1 = INTEGER: 2
iso.0.8802.1.1.2.1.4.2.1.3.796102.1.8.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.1 = INTEGER: 2
iso.0.8802.1.1.2.1.4.2.1.3.1148938.5.6.1.4.10.0.1.2 = INTEGER: 2
iso.0.8802.1.1.2.1.4.2.1.3.1148938.5.6.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.2 = INTEGER: 2
iso.0.8802.1.1.2.1.4.2.1.4.796102.1.8.1.4.10.0.1.1 = INTEGER: 0
iso.0.8802.1.1.2.1.4.2.1.4.796102.1.8.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.1 = INTEGER: 0
iso.0.8802.1.1.2.1.4.2.1.4.1148938.5.6.1.4.10.0.1.2 = INTEGER: 0
iso.0.8802.1.1.2.1.4.2.1.4.1148938.5.6.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.2 = INTEGER: 0
iso.0.8802.1.1.2.1.4.2.1.5.796102.1.8.1.4.10.0.1.1 = OID: iso.3.6.1.2.1.2.2.1.1
iso.0.8802.1.1.2.1.4.2.1.5.796102.1.8.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.1 = OID: iso.3.6.1.2.1.2.2.1.1
iso.0.8802.1.1.2.1.4.2.1.5.1148938.5.6.1.4.10.0.1.2 = OID: iso.3.6.1.2.1.2.2.1.1
iso.0.8802.1.1.2.1.4.2.1.5.1148938.5.6.2.16.32.0.0.0.0.1.0.0.0.0.0.0.0.0.0.2 = OID: iso.3.6.1.2.1.2.2.1.1

- Description for the changelog

[qiluo-msft]

(remote_index,) + (subtype,) + mgmt_ip_sub_oid [](start = 37, length = 46)

You don't need first element in other places, why not just remove? #Closed

[samaity]

Yeah, I tried to do it. But to maintain the uniformity with other OS, I kept it this way. Also, during testing, I faced issues to pass some test cases which is currently not part of the current repo like test_ipv6_rem_man_addr, test_ipv4_rem_man_addr etc. as those test cases were removed from repo by #112 PR.

[qiluo-msft]

16 [](start = 43, length = 2)

Could you double check whether it is 6?

[samaity]

Sure. I checked other OS like cisco and did the snmpwalk for the same oid i.e. 1.0.8802.1.1.2.1.4.2. It's 16.

OBJECT  peerAddressType
     SYNTAX  InetAddressType { ipv4(1), ipv6(2) }
     DESCRIPTION
         "An implementation is only required to support IPv4
          and IPv6 addresses."

     OBJECT  peerAddress
     SYNTAX  InetAddress (SIZE(4|16))
     DESCRIPTION
         "An implementation is only required to support IPv4
          and globally unique IPv6 addresses."

[qiluo-msft]

As comments

[qiluo-msft]

if len(sub_id) == 0 [](start = 8, length = 19)

What happened if len(sub_id) == 1