Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ASIC_TEMPERATURE attributes from sairedis recording #1375

Merged
merged 1 commit into from
May 25, 2024

Conversation

saksarav-nokia
Copy link
Contributor

Skip SAI_SWITCH_ATTR_TEMP_LIST, SAI_SWITCH_ATTR_MAX_TEMP and SAI_SWITCH_ATTR_AVERAGE_TEMP attributes from sairedis recording since they are polled in every polling interval

@saksarav-nokia
Copy link
Contributor Author

@kcudnik , Please review

@saksarav-nokia
Copy link
Contributor Author

@kcudnik , The following errors don't seem to be related to my changes. Could you please check?

2024-05-03T07:00:35.3530529Z [ OK ] ClientServerSai.MCAST_FDB_ENTRY (7 ms)
2024-05-03T07:00:35.3530896Z [ RUN ] ClientServerSai.NEIGHBOR_ENTRY
2024-05-03T07:00:35.3588404Z Assertion failed: pfd.revents & POLLIN (src/signaler.cpp:265)
2024-05-03T07:00:35.6283404Z /bin/bash: line 6: 24157 Aborted (core dumped) ${dir}$tst
2024-05-03T07:00:35.6310396Z FAIL: tests
2024-05-03T07:00:35.6333449Z ===================
2024-05-03T07:00:35.6333615Z 1 of 2 tests failed
2024-05-03T07:00:35.6333720Z ===================
2024-05-03T07:00:35.6344952Z make[3]: Leaving directory '/__w/1/s/unittest/lib'
2024-05-03T07:00:35.6345307Z make[2]: Leaving directory '/__w/1/s/unittest/lib'
2024-05-03T07:00:35.6352726Z make[3]: *** [Makefile:1975: check-TESTS] Error 1
2024-05-03T07:00:35.6353348Z make[2]: *** [Makefile:2101: check-am] Error 2
2024-05-03T07:00:35.6354243Z make[1]: *** [Makefile:405: check-recursive] Error 1
2024-05-03T07:00:35.6360517Z make[1]: Leaving directory '/__w/1/s/unittest'
2024-05-03T07:00:35.6366782Z make: *** [Makefile:460: check-recursive] Error 1
2024-05-03T07:00:35.6380667Z
2024-05-03T07:00:35.6454915Z ##[error]Bash exited with code '2'.
2024-05-03T07:00:35.6539806Z ##[section]Finishing: Run sonic sairedis unit tests

@kcudnik
Copy link
Collaborator

kcudnik commented May 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented May 8, 2024

This error seems to be related to zmq

@kcudnik
Copy link
Collaborator

kcudnik commented May 10, 2024

no issue now :)

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@kcudnik kcudnik merged commit d4a085f into sonic-net:master May 25, 2024
17 checks passed
@kcudnik
Copy link
Collaborator

kcudnik commented May 25, 2024

i'm wondering whether not move to to some config file, or add sairedis API for OA to make control what's recorded or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants