Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add y-cable driver for simulated mux #213

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

wangxin
Copy link
Contributor

@wangxin wangxin commented Aug 19, 2021

Description

This PR added y-cable driver for simulated mux. This y-cable driver conforms with the requirement of https://github.com/Azure/SONiC/pull/757/files

Motivation and Context

After the abstract y-cable base class is added for multi-vendor y-cable support, we also need a y-cable driver for simulated mux used in lab testing.

How Has This Been Tested?

  1. Update the xcvrd package in pmon docker to include the changes in [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd sonic-platform-daemons#197
  2. Update the sonic_y_cable package in pmon docker to include the changes in this PR.
  3. Create /etc/sonic/config_db.json on DUT.
  4. Restart the pmon docker.
  5. Run some dualtor test scripts.
  6. Check mux status on dualtor testbed.

Additional Information (Optional)

@wangxin wangxin requested a review from vdahiya12 August 19, 2021 13:50
@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2021

This pull request introduces 6 alerts when merging 4139dfc into ce51894 - view on LGTM.com

new alerts:

  • 2 for Illegal raise
  • 2 for Wrong number of arguments in a call
  • 1 for Too few arguments in formatting call
  • 1 for Unused argument in a formatting call

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request introduces 6 alerts when merging 500e137 into ce51894 - view on LGTM.com

new alerts:

  • 2 for Illegal raise
  • 2 for Wrong number of arguments in a call
  • 1 for Too few arguments in formatting call
  • 1 for Unused argument in a formatting call

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request introduces 2 alerts when merging d6be8cd into ce51894 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a call

@wangxin
Copy link
Contributor Author

wangxin commented Aug 20, 2021

Python lib requests is not available in the pmon docker. Need to update the code to use urllib.

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2021

This pull request introduces 1 alert when merging 62466cb into ce51894 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2021

This pull request introduces 1 alert when merging 141b3b6 into c17c370 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@wangxin wangxin merged commit 0dc71c1 into sonic-net:master Aug 25, 2021
qiluo-msft pushed a commit that referenced this pull request Aug 25, 2021
Description
This PR added y-cable driver for simulated mux. This y-cable driver conforms with the requirement of https://github.com/Azure/SONiC/pull/757/files

Motivation and Context
After the abstract y-cable base class is added for multi-vendor y-cable support, we also need a y-cable driver for simulated mux used in lab testing.

How Has This Been Tested?
Update the xcvrd package in pmon docker to include the changes in [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd sonic-platform-daemons#197
Update the sonic_y_cable package in pmon docker to include the changes in this PR.
Create /etc/sonic/config_db.json on DUT.
Restart the pmon docker.
Run some dualtor test scripts.
Check mux status on dualtor testbed.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants