Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for port auto negotiation feature #3376

Merged
merged 5 commits into from
May 30, 2021

Conversation

Junchao-Mellanox
Copy link
Contributor

Description of PR

Summary:
Add test cases for port auto negotiation feature

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Add test cases for port auto negotiation feature

How did you do it?

  1. Add test case to verify "config interface advertised-speeds <interface_name> all"
  2. Add test case to verify "config interface advertised-speeds <interface_name> "
  3. Add test case to verify "config interface speed <interface_name> "

How did you verify/test it?

Manually run the test case on Mellanox platform

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

@Junchao-Mellanox Junchao-Mellanox requested review from jleveque and a team as code owners April 21, 2021 05:43
@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2021

This pull request introduces 1 alert when merging b3f1f1f into 95039c7 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@Junchao-Mellanox
Copy link
Contributor Author

The test failure is not related to the change.

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque jleveque added the New label Apr 28, 2021
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some minor cosmetic changes required

tests/common/devices/sonic.py Show resolved Hide resolved
tests/platform_tests/test_auto_negotiation.py Show resolved Hide resolved
tests/platform_tests/test_auto_negotiation.py Show resolved Hide resolved
tests/platform_tests/test_auto_negotiation.py Show resolved Hide resolved
@Junchao-Mellanox Junchao-Mellanox requested review from liat-grozovik and removed request for a team May 25, 2021 11:18
@wangxin
Copy link
Collaborator

wangxin commented May 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit 86a2121 into sonic-net:master May 30, 2021
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
- Summary:
Add test cases for port auto negotiation feature

- What is the motivation for this PR?
Add test cases for port auto negotiation feature

- How did you do it?
Add test case to verify "config interface advertised-speeds <interface_name> all"
Add test case to verify "config interface advertised-speeds <interface_name> "
Add test case to verify "config interface speed <interface_name> "

- How did you verify/test it?
Manually run the test case on Mellanox platform

- Any platform specific information?
N/A

- Supported testbed topology if it's a new test case?
N/A
@Junchao-Mellanox Junchao-Mellanox deleted the test-auto-neg-review branch October 29, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants