Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACACS] fix src\tacacs\bash_tacplus\debian\rules file mode, which cause dirty image version. #9821

Merged

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jan 21, 2022

Why I did it

src\tacacs\bash_tacplus\debian\rules file mode is 644, and debian build will change it to 755, which will cause image version contains 'dirty'

How I did it

Change src\tacacs\bash_tacplus\debian\rules file mode to 755

How to verify it

Check the image version not contains dirty

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • [*] 202111

Description for the changelog

Change src\tacacs\bash_tacplus\debian\rules file mode to 755

A picture of a cute animal (not mandatory but encouraged)

…cause it will be change to 755 by debian build and cause dirty image version.
@liuh-80 liuh-80 requested a review from lguohan as a code owner January 21, 2022 08:35
@liuh-80 liuh-80 requested a review from xumia January 21, 2022 08:35
@liuh-80 liuh-80 added the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 21, 2022
@liuh-80 liuh-80 merged commit e639dda into sonic-net:master Jan 21, 2022
judyjoseph pushed a commit that referenced this pull request Jan 23, 2022
…cause it will be change to 755 by debian build and cause dirty image version. (#9821)

#### Why I did it
    src\tacacs\bash_tacplus\debian\rules file mode is 644, and debian build will change it to 755, which will cause image version contains 'dirty'

#### How I did it
    Change src\tacacs\bash_tacplus\debian\rules file mode to 755

#### How to verify it
    Check the image version not contains dirty

#### Which release branch to backport (provide reason below if selected)

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [*] 202111

#### Description for the changelog
    Change src\tacacs\bash_tacplus\debian\rules file mode to 755

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants