[device] as5712-54x, fix Python error and log location #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanutil.py & thermalutil.py: - TabError: inconsistent use of tabs and spaces in indentation accton_as5712_monitor.py: - NameError: name 'sys' is not defined Signed-off-by: Christian Svensson <blue@cmd.nu>
The platform monitor and setup scripts create two log files in the directory they are launched in - as5712_54x.log and accton_as5712_monitor.log. Move them to /var/log. Signed-off-by: Christian Svensson <blue@cmd.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The service
as5712-platform-monitor.servicewas listed as failed on my AS5712-54X device.How I did it
Looking at the logs and resolving the three Python3 exceptions allowed the service to start. Then I detected some log files that were created straight in the root (/), so I moved them.
How to verify it
Run SONiC on an Edge-core/Accton AS5712-54X and see the service now work.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)