Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against telemetry container restarts when config fields do not exist #9263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AidanCopeland
Copy link

@AidanCopeland AidanCopeland commented Nov 15, 2021

[dockers] Protect against telemetry container restarts when config fields do not exist

What I did
This PR fixes a bug in jq handling in the case where a lookup is made for a field that does not exist or is empty

Why I did it

Without this fix the telemetry container continually restarts until it hits the restart limit

How I did it

Provide additional checks against "null", being the value returned by jq if the field does not exist or is empty

How to verify it

Verified in internal testing with framewave

Description for the changelog

Fix handling of jq lookups for empty or non-existent fields

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Aidan Copeland acopeland@microsoft.com

@AidanCopeland AidanCopeland changed the title Test against "null" to determine whether jq has returned a value Protect against telemetry container restarts when config fields do not exist Nov 15, 2021
@AidanCopeland AidanCopeland marked this pull request as ready for review November 15, 2021 14:25
@TACappleman
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9263 in repo Azure/sonic-buildimage

@TACappleman
Copy link
Contributor

@lguohan could you review this fix, or find someone to do so please?

@TACappleman
Copy link
Contributor

@lguohan could you find us a reviewer for this PR please?

@TACappleman
Copy link
Contributor

@lguohan please can you review this PR?

@TACappleman
Copy link
Contributor

@rlhui could you help us find a reviewer for this PR?

@AidanCopeland could you comment "/azpw run" to retry the pipeline?

@AidanCopeland
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@JohnSalloway
Copy link

@lguohan are you able to review this PR or suggest a reviewer for us?
Thanks

@JohnSalloway
Copy link

@qiluo-msft Are you able to review this PR (Rita suggested I ask you).
Thanks

@qiluo-msft
Copy link
Collaborator

@yozhao101 Please help review this PR.

@yozhao101
Copy link
Contributor

@yozhao101 Please help review this PR.

Acked and will review.

@JohnSalloway
Copy link

@qiluo-msft and @yozhao101 : Thanks for following up.

@yozhao101
Copy link
Contributor

yozhao101 commented Jan 26, 2022

@lguohan could you find us a reviewer for this PR please?

We have another PR under reviewing: https://github.com/Azure/sonic-buildimage/pull/9600/files which can fix the issue addressed in this PR.

@yozhao101
Copy link
Contributor

yozhao101 commented Jan 26, 2022

We have another PR under reviewing: https://github.com/Azure/sonic-buildimage/pull/9600/files which can fix this issue addressed in this PR.

We have another PR under reviewing: https://github.com/Azure/sonic-buildimage/pull/9600/files which can fix the issue addressed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants