Tjcw fix vtysh for -f - #9148
Open
Tjcw fix vtysh for -f - #9148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Apologies for forgetting to sign off the commit with '-s' |
tjcw
force-pushed
the
tjcw-fix-vtysh-for--f
branch
from
5209d3d
to
4ed4a43
Compare
|
@lguohan please review this PR |
|
@lguohan what is the next step for this PR ? I think it is ready for review and merge, but if you think it needs further developement please let me know what area I should attend to. Thanks ! Chris Ward, IBM. |
1 similar comment
|
@lguohan what is the next step for this PR ? I think it is ready for review and merge, but if you think it needs further developement please let me know what area I should attend to. Thanks ! Chris Ward, IBM. |
|
@lguohan what is the next step for this PR ? IBM would like it integrated into master so that I do not have to maintain a separate branch. |
Pick up revisions from master
Signed-off-by: Chris Ward <tjcw@uk.ibm.com>
Signed-off-by: Chris Ward <tjcw@uk.ibm.com>
tjcw
force-pushed
the
tjcw-fix-vtysh-for--f
branch
from
24ce8d5
to
cf79497
Compare
|
is this upstreamed to frr community? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
I needed vtysh to be able to take input from a pipe, i.e. something like
{
echo list
echo list
} | vtysh -f -
How I did it
I made changes to the file handling in vtysh so that piped input works; the old code had a dependency on the -f value representing a real file and not a pipe, I removed this dependency
How to verify it
Try
{
echo list
echo list
} | docker -i bgp vtysh
to the SONiC shell
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)