[PINS] Add submit to ingress port to copp_cfg file #9084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donNewtonAlpha
force-pushed
the
pins/submit-to-ingress-port
branch
from
77db694
to
4523289
Compare
bocon13
changed the title
|
@prsunny this is related to sonic-net/sonic-swss#1952 |
|
lgtm @mint570 How do we get these changes back into our repo ? |
bocon13
commented
Oct 29, 2021
Comment on lines
+64
to
+65
| "trap.group.send_to_ingress" : { | ||
| "submit_to_ingress_name" : "send_to_ingress" |
There was a problem hiding this comment.
Can we move this to the CONFIG_DB port table?
Issue: we can't specify that this is a host interface for CPU there today.
Can we move this to the P4Orch constructor?
There was a problem hiding this comment.
CoPP group has policers and other things. It doesn't really fit here.
There was a problem hiding this comment.
Proposal for MVP: put it in P4Orch
Longer term: make this part of the PORT_TABLE
donNewtonAlpha
force-pushed
the
pins/submit-to-ingress-port
branch
from
4523289
to
f890426
Compare
Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0
Co-authored-by: Glenn Connery <gconnery@google.com>
Signed-off-by: Brian O'Connor <bocon@opennetworking.org>
donNewtonAlpha
force-pushed
the
pins/submit-to-ingress-port
branch
from
f890426
to
f9e7e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0
Co-authored-by: Glenn Connery gconnery@google.com
Depends on:
Why I did it
Adds support for submit_to_ingress port required for PINS packet out path
More details in this HLD:
https://github.com/pins/SONiC/blob/master/doc/pins/Packet_io.md
How to verify it
Build the SONiC image and verify that the submit_to_ingress netdev is created
Which release branch to backport (provide reason below if selected)
None
Description for the changelog
Add submit to ingress port to copp_cfg file