[Accton][PDDF] Fix high CPU utilization caused by chassis.get_change_event() #8905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* correct the wait and timeout mechanism for better CPU usage. * Models: as7326-56x, as7726-32x, as7816-64x, as9716-32x Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #8900
but only for PDDF models: AS7326-56x, as7726-32x, as7816-64x, as9716-32x
Why I did it
Correct get_change_event() wait and timeout mechanism to avoid high CPU utilization.
How I did it
Make sure get_change_event() behaves as documentation said: can block the caller and handle timeout appropriately.
How to verify it
In pmon,
Which release branch to backport (provide reason below if selected)
Description for the changelog
[Accton][PDDF] Fix xcvrd busy issue
A picture of a cute animal (not mandatory but encouraged)