[Accton/AS4630] update reg use for new CPLD FW #8115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update CPLD reg use: fan_dir, LEDs(POE, DIAG, PSU1/2, FAN) and
PSU power_good
2. Improve the PSU model/serial_num reading to avoid illegal char.
3. Correct typos in cpld.c
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please merge #5389 before this PR. I will fix the conflict then. Thanks. |
|
can you resolve conflict? |
Done. Thanks |
* Correct tx_disable reg bit polarity. Signed-off-by: Sean Wu <sean_wu@edge-core.com>
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
|
The code was fixed by PR8450 & PR9744. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models : AS4630-54PE, AS4630-54TE
PSU power_good
Improve the PSU model/serial_num reading to avoid illegal char.Done by PR#5389Signed-off-by: Sean Wu sean_wu@edge-core.com
Why I did it
Change registers use according to the newly released CPLD FW spec.
How I did it
Change registers use according to the newly released CPLD FW spec.
How to verify it
show platform psustatus, check if there are no illegal characters within.Which release branch to backport (provide reason below if selected)
Description for the changelog
[Accton/AS4630] update reg use for new CPLD FW
A picture of a cute animal (not mandatory but encouraged)