[procdockerstatsd] add missing unit conversion #7151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Mar 25, 2021
jleveque
suggested changes
Mar 25, 2021
jleveque
previously approved these changes
Mar 25, 2021
hui-ma
previously approved these changes
Mar 25, 2021
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Mar 26, 2021
Fixing same issue in 201911 as mention here #7151
|
@pra-moh: Please enhance the existing test case to test the new units: https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-host-services/tests/procdockerstatsd_test.py#L27 |
jleveque
suggested changes
Mar 31, 2021
jleveque
previously approved these changes
Mar 31, 2021
lguohan
reviewed
Apr 9, 2021
| ('7.751GiB', 8322572878), | ||
| ('8.1TiB', 8906044184986), | ||
| ('12TB', 12000000000000), | ||
| ('2.25TB', 2250000000000) |
There was a problem hiding this comment.
the test is too simple, we need to have a test that convert from the ps -e output and test the content in the database as end-to-end test.
There was a problem hiding this comment.
I think this test is appropriate to the convert_to_bytes() method. More test cases need to be added in order to ensure full end-to-end functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Observed state_db contains 'None' as value for BLOCK_OUT_BYTES
"227a593e011f":{"BLOCK_IN_BYTES":"107000000","BLOCK_OUT_BYTES":"None","CPU%":"0.68","MEM%":"2.37","MEM_BYTES":"1983905792","MEM_LIMIT_BYTES":"8359080099840","NAME":"bgp","NET_IN_BYTES":"0","NET_OUT_BYTES":"0","PIDS":"21"
For BGP docker Block O is in GB and script is missing this conversion
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)