Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master][build] fix compile error when enable nostrip #6058

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tim-rj
Copy link
Contributor

@tim-rj tim-rj commented Nov 29, 2020

Signed-off-by: tim-rj sonic_rd@ruijie.com.cn

- Why I did it
fix #5982
- How I did it
check notrip option before handle dbgsym debs
- How to verify it
set SONIC_DEBUGGING_ON=y / SONIC_PROFING_ON=y and compile the whole image
- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

If SONIC_DEBUG_ON or SONIC_PROFILING_ON set to y, no dbgsym debs will be stripped from the origin deb, so mv dbgsym deb to some other folders will fail and compiling will stop.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
@tim-rj tim-rj changed the title [master][build] fix compile error when enable notrip [master][build] fix compile error when enable nostrip Nov 30, 2020
@lguohan
Copy link
Collaborator

lguohan commented Dec 2, 2020

it seems DBG_TARGETS is newly introduced, can you rename it as DEBUG_TARGETS?

renukamanavalan
renukamanavalan previously approved these changes Dec 2, 2020
Copy link
Contributor

@renukamanavalan renukamanavalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Guohan's comments. The change looks good.

@tim-rj
Copy link
Contributor Author

tim-rj commented Dec 3, 2020

it seems DBG_TARGETS is newly introduced, can you rename it as DEBUG_TARGETS?

ok

Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
@lguohan
Copy link
Collaborator

lguohan commented Dec 24, 2020

what is the use case to enable nostrip option during the build? I am not aware of this. @tim-rj , @renukamanavalan , what is the use case here?

@tim-rj
Copy link
Contributor Author

tim-rj commented Dec 25, 2020

@lguohan when enable SONIC_DEBUGGING_ON or SONIC_PROFILING_ON micro, "notrip“” option will be added in slave.mk.


ifneq ($(findstring nostrip,$(DEB_BUILD_OPTIONS)),nostrip)
$(eval DERIVED_TARGETS += $(DEBUG_TARGETS))
endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is common across different Makefile, then I think it is better to be move to common place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
@pettershao-ragilenetworks
Copy link
Contributor

help forward this, thanks!

@tim-rj tim-rj requested review from a team as code owners June 10, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[build] [debug] [201911] compile failed when enable SONIC_DEBUGGING_ON or SONIC_PROFILING_ON
4 participants