Fix bgpmon.py packaging issue for console_scripts entry point #5436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Sep 23, 2020
src/sonic-bgpcfgd/setup.py
Outdated
| @@ -12,7 +12,7 @@ | |||
| scripts=['bgpcfgd'], | |||
| entry_points={ | |||
| 'console_scripts': [ | |||
| 'bgpmon = bgpmon:main', | |||
| 'bgpmon = bgpmon_proj.bgpmon:main', | |||
There was a problem hiding this comment.
Suggest naming the new directory bgpmon rather than bgpmon_proj. Then this line becomes 'bgpmon = bgpmon.bgpmon:main',.
There was a problem hiding this comment.
@jleveque Agreed.
jleveque
approved these changes
Sep 23, 2020
|
Retest mellanox please |
|
retest vsimage please |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…net#5436) * Fix bgpmon.py packaging issue for console_scripts entry point * renamed directory from bgpmon_proj to bgpmon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix "https://github.com/Azure/sonic-buildimage/pull/5329/files" where the bgpmon code itself was not properly packaged for the console_scripts entry point and causing the bgpmon daemon unable to start since bgpmon.py was not found.
it was not caught earlier due to the build was not cleaned up properly that installed the bgpmon.py via the scripts method.
Signed-off-by: Gen-Hwa Chiang gechiang@microsoft.com
- What I did
Created a new project directory and moved bgpmon.py into that directory for packaging purpose.
Change the setup.py file to indicate where to expect the bgpmon.py in the console_scripts specification.
- How to verify it
once the BGP docker is up and running, you can perform "show services" to see that this new daemon "bgpmon.py" is running under the BGP docker service similar to the following output: